search

westerndigitalcorporation / swerv-ISS

Western Digital’s Open Source RISC-V SweRV Instruction Set Simulator
200 stars 41 forks source link

Win32 porting #8

Closed jmonesti closed 5 years ago

jmonesti commented 5 years ago

Using Mingw toolchain in a Cygwin64 shell.

Then, build with: make CXX=/cygdrive/c/mingw/bin/g++.exe BOOST_ROOT=c:/mingw/include

jrahmeh commented 5 years ago

Hi Jmonesti,

This pull request has three components:

  1. Port linenoise to c++.
  2. Fix/improve printf formatting (use STDC_FORMAT_MACROS).
  3. Port to MINGW.

I would prefer to keep linenoise as is to simplify upgrading to new versions as they become available. Are the changes in 1 essential to your work. Will you be willing to re-submit without 1?

Thanks,

Joe

jmonesti commented 5 years ago

Hi Joe,

Unfortunately, antirez/linenoise is not portable to Win32. Please refer to issue #113. I went into the exact same trouble (#include <termios.h> not found).

I found several alternatives, eg. arangodb/linenoise-ng msteveb/linenoise yhirose/cpp-linenoise

I chose the last one, as it's the most straightforward to drop in Whisper.

Any thought ? Jean-François

jrahmeh commented 5 years ago

HI Jean-Francois,

That makes sense. I will merge your pull request later today.

Joe

On Mon, Apr 8, 2019 at 3:43 AM jmonesti notifications@github.com wrote:

Hi Joe,

Unfortunately, antirez/linenoise is not portable to Win32. Please refer to issue

113 https://github.com/antirez/linenoise/issues/113. I went into the

exact same trouble (#include not found).

I found several alternatives, eg. arangodb/linenoise-ng https://github.com/arangodb/linenoise-ng msteveb/linenoise https://github.com/msteveb/linenoise yhirose/cpp-linenoise https://github.com/yhirose/cpp-linenoise

I chose the last one, as it's the most straightforward to drop in Whisper.

Any thought ? Jean-François

— You are receiving this because you commented. Reply to this email directly, view it on GitHub https://github.com/westerndigitalcorporation/swerv-ISS/pull/8#issuecomment-480740850, or mute the thread https://github.com/notifications/unsubscribe-auth/ACR4X8BeULGWZ4RwrxPpX5r2X7mBp8n9ks5vewEwgaJpZM4cfJKn .