search

westerndigitalcorporation / ufs-utils

The UFS Tool project have been created to allow access UFS device from user space, and perform basic set of UFS operations: Read and write UFS device configuration (flags, attributes, descriptors), FFU, etc... The set of UFS Tool features is co-existing and updated beside BSG and SG infrastructure in Linux Kernel. The source code of ufs-tool is almost ready and will be uploaded soon!
GNU General Public License v2.0
78 stars 62 forks source link

Reduce duplicate code for exception handling #37

Open elfring opened 2 years ago

elfring commented 2 years ago

The statement “print_error("Memory Allocation problem");” is specified in three branches for the implementation of the function “verify_write”. I find that the message should be sufficient at one source code place. 💭 This could be achieved if a corresponding jump label like “report_allocation_failure” will be applied, couldn't it?

arthur-simchaev-wdc commented 2 years ago

Correct.
Do you want fix it & submit PR? If not I will change it

elfring commented 2 years ago

💭 I would find it nice if you could integrate the proposed change possibilitiy also directly (without another separate pull/merge request from me).

arthur-simchaev-wdc commented 1 year ago

Ok , will be done

Regards Arthur

From: Markus Elfring @.> Sent: Wednesday, June 29, 2022 5:22 PM To: westerndigitalcorporation/ufs-utils @.> Cc: Arthur Simchaev @.>; Comment @.> Subject: Re: [westerndigitalcorporation/ufs-utils] Reduce duplicate code for exception handling (Issue #37)

CAUTION: This email originated from outside of Western Digital. Do not click on links or open attachments unless you recognize the sender and know that the content is safe.

💭 I would find it nice if you could integrate the proposed change possibilitiy also directly (without another separate pull/merge request from me).

— Reply to this email directly, view it on GitHubhttps://github.com/westerndigitalcorporation/ufs-utils/issues/37#issuecomment-1170046963, or unsubscribehttps://github.com/notifications/unsubscribe-auth/ALE5422Z3VTFSYRGDGRCHRDVRRLYVANCNFSM52CNTGKQ. You are receiving this because you commented.Message ID: @.**@.>>