fs: drop empty-file assertion for writable files

westerndigitalcorporation / zenfs

ZenFS is a storage backend for RocksDB that enables support for ZNS SSDs and SMR HDDs.

GNU General Public License v2.0

243 stars 88 forks source link

fs: drop empty-file assertion for writable files #154

Closed yhr closed 2 years ago

yhr commented 2 years ago

We do allow that files can be re-opened for appending (ReopenWritableFile), so drop the assertion that the file is empty when creating a new writable file.

Signed-off-by: Hans Holmberg hans.holmberg@wdc.com

MaisenbacherD commented 2 years ago

Looks good to me!

yhr commented 2 years ago

I checked, and the reason for us having to change the implementation in the first place (allowing appends) was an API redefinition (!) in rocksdb last october, see https://github.com/facebook/rocksdb/commit/a282eff3d14b6881485b188a2a07b8a39e452898