westerndigitalcorporation / zenfs

ZenFS is a storage backend for RocksDB that enables support for ZNS SSDs and SMR HDDs.
GNU General Public License v2.0
238 stars 87 forks source link

build: make zenfs work with cmake build #215

Closed jsvaerke closed 2 years ago

jsvaerke commented 2 years ago

rocksdb has a guideline for how to integrate with the cmake build system. Simply provide plugin specific variables with .cc files and the library requirements.

We run generate_version.sh at cmake time - this should be ok since any change in the git repo could affect cmake, and as such cmake should be rerun anyways. Also, with the current cmake infrastructure in rocksdb, it doesn't seem to be possible to run generate_version.sh at build time prior to processing the zenfs source files.

Signed-off-by: Jorgen Hansen jorgen.hansen@wdc.com

MaisenbacherD commented 2 years ago

Looks good to me :)