search

westerndigitalcorporation / zenfs

ZenFS is a storage backend for RocksDB that enables support for ZNS SSDs and SMR HDDs.
GNU General Public License v2.0
235 stars 86 forks source link

assert(true) #254

Closed sg20180546 closed 9 months ago

sg20180546 commented 1 year ago

hello. I think it is better if assert(true) remove thanks

yhr commented 1 year ago

@sg20180546 Yes, i think we can drop the unconditional assert. Could you format your commit message to motivate the change and provide your signed-off by line (git commit --amend --signoff?).

The subject of the patch should be something like "fs: drop unconditional assert when running out of metadata zones" check the git history for good examples of commit messages.

Thanks!

yhr commented 1 year ago

@sg20180546 : You'll need to signoff with your real name, not your email account number. (Signed-off-by: SungGin Byeon email.adress@domain) . Could you update your patch? Thanks!

yhr commented 9 months ago

Will fix this as part of another PR