Bad testing process for `long_performance`

westerndigitalcorporation / zenfs

ZenFS is a storage backend for RocksDB that enables support for ZNS SSDs and SMR HDDs.

GNU General Public License v2.0

235 stars 86 forks source link

Bad testing process for `long_performance` #268

Closed ywang-wnlo closed 9 months ago

ywang-wnlo commented 1 year ago

for long_performance, current testing process

0000_fillrandom.sh
0001_overwrite.sh
0002_readwhilewriting_ratelimit.sh

However, fillrandom will cause the inserted data to not fully cover the specified key range, which will result in read tests not querying the corresponding key, affecting the correctness of the experiment.

Recommend replacing fillrandom with fillseq. Or using filluniquerandom directly to ensure the integrity of the inserted data.

yhr commented 9 months ago

Having some missing keys is also a valid test. The random fill is great for preconditioning, so we don't want to use fillseq. We could consider moving to filluniquerandom in the future through.