westerndigitalcorporation / zenfs

ZenFS is a storage backend for RocksDB that enables support for ZNS SSDs and SMR HDDs.
GNU General Public License v2.0
235 stars 86 forks source link

error: zenfs.mk:37: *** Generating ZenFS version failed #269

Closed zhoulening969 closed 1 year ago

zhoulening969 commented 1 year ago

Hello gentlemen, I got some errors about compiling source code. If only rocksdb is compiled, there is no problem, but adding the Zenfs plugin will result in an error. Please help me. Thanks, Eddy

OS INFO Centos : 7.9.2009(core) Kernel : 6.3.1-1.el7.elrepo.x86_64

ERRORS [root@localhost rocksdb]# DEBUG_LEVEL=0 ROCKSDB_PLUGINS=zenfs make -j48 db_bench install $DEBUG_LEVEL is 0 plugin/zenfs/zenfs.mk:37: *** Generating ZenFS version failed. [root@localhost rocksdb]#

yhr commented 1 year ago

Thanks for reporting, i'll try to reproduce the issue.

On Thu, 11 May 2023, 13:55 Zhou Lening, @.***> wrote:

Hello gentlemen, I got some errors about compiling source code. If only rocksdb is compiled, there is no problem, but adding the Zenfs plugin will result in an error. Please help me. Thanks, Eddy

OS INFO Centos : 7.9.2009(core) Kernel : 6.3.1-1.el7.elrepo.x86_64

ERRORS @. rocksdb]# DEBUG_LEVEL=0 ROCKSDB_PLUGINS=zenfs make -j48 db_bench install $DEBUG_LEVEL is 0 plugin/zenfs/zenfs.mk:37: Generating ZenFS version failed. @.*** rocksdb]#

— Reply to this email directly, view it on GitHub https://github.com/westerndigitalcorporation/zenfs/issues/269, or unsubscribe https://github.com/notifications/unsubscribe-auth/AADNGODNAUATIG6XS5XHDJLXFTHTDANCNFSM6AAAAAAX6AXTZA . You are receiving this because you are subscribed to this thread.Message ID: @.***>

zhoulening969 commented 1 year ago

After investigation, I found that the value of $(. SHELLSTATUS) is abnormal, but the version. h file can be generated normally and its content is # define ZENFS_ VERSION "v2.1.0-57-gb04ca0c-dirty".

Then I annotated the following statement in zenfs.mk: ifneq ($(.SHELLSTATUS),0) $(error Generating ZenFS version failed) endif

Make again, and an error is reported as follows: [ root@localhost rocksdb]# DEBUG LEVEL=0 ROCKSDB PLUGINS=zenfs make -j48 db bench install $DEBUG LEVEL is 0 Makefile:286: *** pkg-config failed。

My pkg-config version is 0.29.2 and gcc version is 11.3.0.

yhr commented 1 year ago

I built the latest rocksdb + zenfs master without an issue with my system. Hmm. @MaisenbacherD : have you run across something like the error reported here?

MaisenbacherD commented 1 year ago

Hi @zhoulening969, This looks similar to the issue https://github.com/westerndigitalcorporation/zenfs/issues/101

What RocksDB and ZenFS commits are you trying to build?

zhoulening969 commented 1 year ago

Hi @zhoulening969, This looks similar to the issue #101

What RocksDB and ZenFS commits are you trying to build?

the latest rocksdb + zenfs master

MaisenbacherD commented 1 year ago

I also build the latest rocksdb (v8.1.1) + zenfs master without an issue on my system.

Are you able to reproduce that issue with a clean copy of rocksdb and zenfs?

zhoulening969 commented 1 year ago

@yhr @MaisenbacherD I tried to replace the server's make and cmake versions with the latest versions available, and then the compilation was successful. Thank you all the same! Best, Zhou