westerndigitalcorporation / zenfs

ZenFS is a storage backend for RocksDB that enables support for ZNS SSDs and SMR HDDs.
GNU General Public License v2.0
235 stars 86 forks source link

Fix rocksdb6 segfault #282

Closed yhr closed 9 months ago

yhr commented 10 months ago

util: Fix segfault when doing a backup with an empty backup_path Revert change of 'util: Fix occurances where back() might be called on an empty string' for zenfs_tool_backup().

Otherwise test/utils/0040_backup.sh segfaults when building ZenFS with RocksDB 6.29.fb (c++11).

yhr commented 9 months ago

LGTM

Thanks @aravind-wdc ! Great to get this sorted, now the nightly rocksdb 6 tests will pass