search

westerndigitalcorporation / zenfs

ZenFS is a storage backend for RocksDB that enables support for ZNS SSDs and SMR HDDs.
GNU General Public License v2.0
239 stars 87 forks source link

Header file updates does not trigger zenfs object files to rebuild #73

Closed yhr closed 2 years ago

yhr commented 2 years ago

For some reason, updates to header files require a clean rebuild to propagate. This can manifest in very hard-to-debug issues if one forgets to do a clean rebuild.

It looks like rocksdb is supporting the -mm header file dependency handling, but this might be broken for plugins.

MaisenbacherD commented 2 years ago

Pull request for RocksDB was submitted: https://github.com/facebook/rocksdb/pull/9120

MaisenbacherD commented 2 years ago

Also submitted pull request for ZenFS to ignore the dependency files: https://github.com/westerndigitalcorporation/zenfs/pull/77

yhr commented 2 years ago

all done!