search

westerveltco / django-simple-nav

A simple, flexible, and extensible navigation menu for Django
https://django-simple-nav.westervelt.dev
MIT License
10 stars 0 forks source link

Add `active` attribute to the `NavGroup` if a `NavItem` within it is active #56

Closed joshuadavidthomas closed 1 hour ago

joshuadavidthomas commented 4 months ago

Should the NavGroup also get an active attribute added to it if it contains an item that is active?

I think django-simple-menu does this, but it's behind a setting.. Could either do that or just have it be the default to simplify things.

joshuadavidthomas commented 2 hours ago

Yes, I think this is a worthwhile improvement. Let's go forward with it and not put it behind a setting flag. This library is new enough and still sub v1.0 that introducing a breaking change like this shouldn't be a big deal, as long as it's highlighted in the release notes.