search

westerveltco / django-twc-project

A Django template for all web applications at The Westervelt Company
MIT License
23 stars 2 forks source link

Disconnect between Node version specified in Dockerfile and Node version installed #256

Closed joshuadavidthomas closed 2 months ago

joshuadavidthomas commented 2 months ago

https://github.com/westerveltco/django-twc-project/blob/b62472fe5b9435c07503785ddbe15b956e701461/src/django_twc_project/Dockerfile.jinja#L3 https://github.com/westerveltco/django-twc-project/blob/b62472fe5b9435c07503785ddbe15b956e701461/src/django_twc_project/Dockerfile.jinja#L60

joshuadavidthomas commented 2 months ago

Though! We do correctly add the apt repository for the node version specified:

https://github.com/westerveltco/django-twc-project/blob/f4d61d182a25218166a8010ab54981a2a74dc835/src/django_twc_project/Dockerfile.jinja

So, maybe this isn't a problem. If it only has access to the apt repo for the node version, then latest should only ever point to the one in that repo.

joshuadavidthomas commented 2 months ago

Sure enough, testing in a real world project shows the correct node version:

➜ just console node
docker compose run --rm  node node
Welcome to Node.js v20.16.0.
Type ".help" for more information.
>