search

westes / flex

The Fast Lexical Analyzer - scanner generator for lexing in C and C++
Other
3.54k stars 529 forks source link

build: Correct program path in doc/Makefile.am #650

Closed Explorer09 closed 3 months ago

Explorer09 commented 3 months ago

A build system regression from 3c70fb6932fdc61bddf8371400b6582c2fd5a0e9.

When help2man is invoked with a program path without the directory prefix (such as "./"), it might launch a program installed on the builder's system instead of the program just compiled in the working directory.

Reproducible on a CI server (example build log: https://github.com/Explorer09/flex/actions/runs/9018798317/job/24780203568)

  1. Have an old version of flex installed on the builder's system ("apt install flex" or similar command from your package manager)
  2. Hack src/main.c to alter some help text (like this)
  3. Build flex and the man page with rm -f doc/flex.1 && ./configure && make
  4. cat doc/flex.1 and see the man page isn't updated with altered text.
Explorer09 commented 3 months ago

@westes By the way, I agree with your choice of using install(1) instead of cp in the commit 3c70fb6932fdc61bddf8371400b6582c2fd5a0e9, as that guarantees the program will have the correct, "execute" permission.