search

westfieldlabs / apivore

Tests your rails API against its Swagger description of end-points, models, and query parameters.
Apache License 2.0
213 stars 66 forks source link

Add missing positiveInteger and positiveIntegerDefault0 definitions #10

Closed gwshaw closed 9 years ago

hornc commented 9 years ago

Thanks George, I'm not sure how I missed those, sorry about that!

gwshaw commented 9 years ago

They didn't show up as errors until I used something that referenced them, so potentially there could be others. There is way too much in there to hand check. Better to probably create a swagger file that uses all the possible features and see what beaks.

hornc commented 9 years ago

@gwshaw, I've just done a once off true up with all the #refs and definitions in this file and everything matches now. There are 64 unique definitions referenced, and 64 definitions made.

Some of those defs were originally external and I attempted to bring them over to avoid the json validator making http requests to read them, I obviously missed two, but they are all present now.

For (my) future reference, the commands I used to check the defs and refs:

egrep -o '#/definitions/[^"]+' data/swagger_2.0_schema.json | sort | uniq
tail -n+79 data/swagger_2.0_schema.json | egrep -o '^ {4}".*' | sort