westfieldlabs / apivore

Tests your rails API against its Swagger description of end-points, models, and query parameters.
Apache License 2.0
213 stars 66 forks source link

Update Swagger 2.0 schema and include local draft04 to prevent network calls #49

Closed hornc closed 9 years ago

hornc commented 9 years ago

Previously Apivore used a modified version of the Swagger 2.0 spec that manually included the contents of the $refs to the draft04 schema. Forming this was a manual process.

This PR uses the latest unmodified Swagger 2.0 spec and draft04 and takes advantage of a feature of json-schema that lets us register an external resource locally. This makes getting the latest version of either easier to update and include.

hornc commented 9 years ago

I need to update the license info in the README since the included Swagger 2.0 spec is included unmodified, and we are now including the json schema draft04 too. I'll need to research the license requirements there.

Also, I need to include the new schema file in the gemspec and bump the version etc.

davesag commented 9 years ago

LGTM re code changes. :+1: wrt your comments above