search

westfieldlabs / apivore

Tests your rails API against its Swagger description of end-points, models, and query parameters.
Apache License 2.0
213 stars 66 forks source link

Fixed backwards slash. #57

Closed gwagener closed 9 years ago

gwagener commented 9 years ago

Obviously this path wasn't exercised by any test. Anyone want to write one for me to add to the PR?

hornc commented 9 years ago

LGTM, thanks!

hornc commented 9 years ago

I'm going to need to do further investigation to determine the practical difference between elsif !swagger_checker.has_response_code_for_path?(path, method, expected_response_code) and elsif method == "get" && swagger_checker.fragment(path, method, expected_response_code).nil?

At first glance they look like they could be the same thing...

EDIT: the second one is attempting to enforce GET response models must be filled out with a full response schema. I'll look at adding a test for this.