westlicht / performer

PER|FORMER Eurorack Sequencer
https://westlicht.github.io/performer
MIT License
232 stars 70 forks source link

update openocd? #287

Open tl072 opened 3 years ago

tl072 commented 3 years ago

Hi, while trying to run

make tools_install

I am getting the error

src/svf/svf.c:663:7: error: this statement may fall through [-Werror=implicit-fallthrough=]
     i = -1;
     ~~^~~~
src/svf/svf.c:664:4: note: here
    case '\r':
    ^~~~
src/svf/svf.c:667:8: error: this statement may fall through [-Werror=implicit-fallthrough=]
     if (!cmd_pos)
        ^
src/svf/svf.c:669:4: note: here
    default:
    ^~~~~~~
cc1: all warnings being treated as errors

I think it is the same issue as this https://sourceforge.net/p/openocd/tickets/254/ which indicates that the error has been fixed in newer versions. I am still investigating this but it seems to me that it it may be an issue of updating openocd.

Is openocd required if provided by the linux distribution btw? Is there anything special about the one that is compiled?

tl072 commented 3 years ago

This will fix the compilation issue for anyone coming across this:

diff --git a/Makefile b/Makefile
index c4bb044..b750dc7 100644
--- a/Makefile
+++ b/Makefile
@@ -105,7 +105,7 @@ $(OPENOCD_INSTALL_MARKER):
        $(V1) ( \
          cd $(OPENOCD_BUILD_DIR) ; \
          ./bootstrap ; \
-         ./configure  $(OPENOCD_OPTIONS) ; \
+         ./configure --disable-werror $(OPENOCD_OPTIONS) ; \
          $(MAKE) -j ; \
          $(MAKE) install ; \
        )