westlicht / performer

PER|FORMER Eurorack Sequencer
https://westlicht.github.io/performer
MIT License
232 stars 70 forks source link

Retrigger and Gates Length #321

Open Loorenz68 opened 3 years ago

Loorenz68 commented 3 years ago

It seems there's an issue when adding Retrigger on a step and changing this step Gate Length. For example when Gate Length is set to 50% up to 100%, if I set 4 repetitions on a step, the repetitions are correct. But under a 50% Gate Length even if I set 4 repetitions, there will not be 4 repetitions at the gate out: only 2 repetitions and if the Gate Length is on the shorter setting there will not be repetitions at all.

jaffasplaffa commented 2 years ago

Hey Loorenz68

The reason you only get proper retrigger when notes are longer is because the retrigger only happens when a gate is high.

So if you have 4 retriggers and the length is only set to 25% it will probably only play 1 or 2 of the retriggers, because the gate is not high for a very long time. If you set length to something higher than 25%, it will allow more triggers to happen, cause the gate is still high.

I think this works semi, once you understand it. But I do think deattaching how many retriggers from gate length would be a good idea, as it would allow a bit more control.

The retrigger section could be updated a bit, for example we could get both a rate/speed setting and how many retriggers you want. Like on Elektron sequencers. So you could set a retrigger rate of 64th and also set how many retrigs you want at that specific rate, like 8 for example, with no relation to gate length. You get better control like that. I build my own sequencer in Pure Data and got it working fine.

I do know a bit of c++ and I have been looking a bit around the firmware, but it is a big project, so much to understand. I still need to learn more to be able to contribute with something meaningful.

I guess for now, we have to wait and see :)