Hotfix/resolve timeout issues

westmonroe / pdf-puppeteer

A simple NPM package to convert HTML to PDF for Node applications by using Puppeteer

BSD 3-Clause "New" or "Revised" License

123 stars 27 forks source link

Open cr7boulos opened 4 years ago

cr7boulos commented 4 years ago

This PR resolves timeout issues on #33

cr7boulos commented 4 years ago

Reviewed the docs here: https://pptr.dev/#?product=Puppeteer&version=v2.1.1&show=api-pagegotourl-options Seems like passing 0 to the timeout property should resolve the issue. I was trying to find a massive html file online to test before and after the change to ensure I fixed the issue but did not have any luck.

cjroth commented 3 years ago

Hey, I've applied this change as a patch and I'm still getting the timeout errors. Just FYI.