westnordost / osmapi

Java client for the OSM API 0.6
GNU Lesser General Public License v3.0
97 stars 19 forks source link

functionality to update gpx traces from files #37

Closed jamescr closed 6 months ago

jamescr commented 6 months ago

implements Upload gpx from file #36

jamescr commented 6 months ago

Thanks for the review, i applied the improvements to the code.

westnordost commented 6 months ago

Great, thank you! There is one thing left that is also relevant for your implementation in OSMTracker. You'll likely want to use try-with-resources so that the file handle is always closed also if an IO exception occurs:

try (InputStream in = new FileInputStream(file)) {
  // ...
} catch (IOException e) {
  // ...
}
westnordost commented 6 months ago

Nice, thank you! Will release a new version today.