#15 Using JSON Column instead of YAML encoded object column

[oskargargas]

Hello!

I'd love it to be merged into upstream. I've added configuration to switch between YAML and JSON storage types leaving the default with YAML. And on top of that a simple implementation to use PostgreSQL JSONB columns.

Cheers!

[westonganger]

Solves #15

[westonganger]

Looks pretty good. I've added some comments. Also can you please add tests for all this code too.

[oskargargas]

Looks pretty good. I've added some comments. Also can you please add tests for all this code too.

Nice to hear :) Uploaded fixes to most comments (beside symbol vs string, comment added in conversation). Will add tests when I have a bit more time in work. Hopefully next week.

[westonganger]

Hi @oskargargas any chance to work on this yet?

Also can you add a changelog entry in the PR too.

[oskargargas]

any chance to work on this yet?

Unfortunately not too much. I've added requested changes but I have literally no idea how to add tests. I would say it is needed to run existing tests but with different migrations and for specific dbs only. And on top of that add some change to CI. I've looked at Rakefile and test_helper how it is setup right now but expanding it is too much for me.

[westonganger]

Ok fair, I understand there some larger CI changes that may need to occur.

However can you attempt to add the minimal subset of unit tests? Off the bat I notice the configuration methods can be tested easily.

[oskargargas]

Sure. I added tests for config.

[westonganger]

Continuing this work over on #32

[westonganger]

Thanks for your work starting this.

Closing this as I have now merged the superseding PR for this to master, #32