search

weswilliams / GivWenZen

MIT License
23 stars 21 forks source link

[SOLUTION by veskoy] GivWenZen doesn't parse some data types with the latest version of FitNesse #10

Open zdravko-nestorov opened 4 years ago

zdravko-nestorov commented 4 years ago

Greetings!

Upgrading FitNesse from a 2014 version to latest resulted in some compatibility issues with GivWenZen. Many tests started to fail and a quick debugging session showed that all affected scenarios incorporate the Hash Table markup syntax. The hash table is correctly matched by the regular expression, however it is passed as a String to the @DomainStep method which is expecting a Map.

After a deep investigation I found this Topic and PR:

which perfectly describes the problem and enhance the code with a solution. The solution is hosted in this branch:

I reviewed the code and seems that the implemented solution is small, but with a big effect. To ensure that all is correct, I made lots of tests, and seems to work like a charm. I wanted to ask if it is possible to merge the branch and release an official version that includes the changes from this branch, because this will help a lot of people, using this library.

Is it possible to do this? Thanks a lot in advance.

weswilliams commented 4 years ago

@zdravko-nestorov apologies for taking so long, I am guessing you are regular user and I am not any longer. Are you interested in being a committer?