search

wet-boew / gcweb-jekyll

This repo is intended to be used as a GitHub template. Its documentation is coming soon.
https://wet-boew.github.io/gcweb-jekyll/
MIT License
9 stars 22 forks source link

Use of assets: "https://wet-boew.github.io/themes-dist" led to 404 breakage #23

Open anthonyfok opened 3 years ago

anthonyfok commented 3 years ago

Some websites relying on GCWeb theme broke as asset URLs such as https://wet-boew.github.io/themes-dist/GCWeb/css/theme.min.css went offline (404), see https://github.com/wet-boew/GCWeb/issues/1792

Despite my comment there, in retrospect, I think the real issue is with wet-boew/gcweb-jekyll assuming the GCWeb theme asset files are https://wet-boew.github.io/themes-dist are public and permanent, when in fact they are not.

Setting assets: "https://wet-boew.github.io/themes-dist" in _config.yml, as what is done currently (see https://github.com/wet-boew/gcweb-jekyll/blob/master/_config.yml#L65), is very convenient, and eliminates the need for gcweb-jekyll to pull these files from wet-boew/GCWeb etc., but as today's breakage shows, seems rather unreliable.

Perhaps having these assets stored on the same server of end users' web sites would be a better idea? Or perhaps have those assets stored, with a versioned path, on a CDN for posterity, like how jQuery, Bootstrap etc.?

anthonyfok commented 3 years ago

I just noticed Issue #14 Sass files import from GCWeb. Thank you for that! Fixing #14 should solve this issue (#23) too.

RobJohnston commented 3 years ago

Or perhaps have those assets stored, with a versioned path, on a CDN for posterity

These files can be retrieved from GitHub via jsDelivr. The format is "/gh/user/repo@version/file.js".

For example: https://cdn.jsdelivr.net/gh/wet-boew/themes-cdn@4.0.27-theme-gc-intranet/css/theme.min.css