wet-boew / gcweb-jekyll

This repo is intended to be used as a GitHub template. Its documentation is coming soon.
https://wet-boew.github.io/gcweb-jekyll/
MIT License
9 stars 22 forks source link

Add relative_url in language switcher #39

Open auxonic opened 1 year ago

auxonic commented 1 year ago

I've been working on a little example site using the gcweb jekyll theme for internal use and noticed that the alt lang url doesn't use the relative_url filter like the breadcrumbs do.

That means for sites using subdirectories like most github pages the alt lag url omits the baseurl. For sites running at the root there's no impact from this bug.

I added a note in the default _config.yml file about the value you might set baseurl to as well.

Possible risk: Impact on a site is minimal but for content that has already been created where the baseurl has been manually addded to the altlang url then the content would have to be updated.