search

wet-boew / theme-gcwu-fegc

Government of Canada (GC) Web Usability theme for the Web Experience Toolkit
Other
6 stars 22 forks source link

Search icon or text ? #179

Open crochefort opened 10 years ago

crochefort commented 10 years ago

Good day, I'm working on my V4 website and maybe found an issue.

From the page where the instruction are : http://www.gcpedia.gc.ca/wiki/GC_Web_Search/Adoption_Instructions

They are saying to put and Icon and hide the text. 

<button type="submit" id="wb-srch-sub" class="btn btn-primary btn-small" name="wb-srch-sub"><span class="glyphicon-search glyphicon"></span><span class="wb-inv">Search</span></button>

The issue is it's not what I see on the template : http://wet-boew.github.io/themes-dist/theme-gcwu-fegc/content-en.html

<button type="submit" id="wb-srch-sub" class="btn btn-default">Search</button>

So witch one should we use for V4 ?

The difference is with TBS one, we are seeing the glypicon for the Search and no wording. From the template the word Search.

Thank you

crochefort commented 10 years ago

@pjackson28 and @LaurentGoderre this might be for you by the way!

LaurentGoderre commented 10 years ago

It seems that those instructions apply for the GCWeb but not the GCWeb theme

pjackson28 commented 10 years ago

Yes, the instructions seem specific to the Canada.ca theme rather than the GC Web Usability theme. Perhaps the instructions on GCPedia should be updated to show both the Canada.ca theme code and the GC Web Usability theme code.

/cc @laurawesley

LaurentGoderre commented 10 years ago

@pjackson28 I did forward it to them