wet-boew / theme-ogpl

Theme developed to support the Open Government Platform (OGPL).
Other
0 stars 12 forks source link

Search: Fixed layout issues with minified HTML/RTL. #134

Closed EricDunsworth closed 7 years ago

EricDunsworth commented 7 years ago

In medium/large views, the search field/button's layout used to rely on space/line break/tab characters being present in-between their elements in HTML markup. Their presence produced a space in-between the search field/button. But in pages that use minified HTML, the space disappeared, which made the field and button "stick" together.

It turns out that this theme's small view and under SCSS file contained selectors that produced a predictable amount of space for the search feature in noscript/wbdisable mode. But its default selector's properties were redeclared in the right to left (RTL) selector instead of being inverted.

This commit moves the aforementioned selectors into this theme's screen SCSS file and corrects the RTL selector's properties. Combined, these resolve layout issues in medium/large views and fix RTL layouts in smaller views.

Related to wet-boew/wet-boew#8061.