wet-boew / wet-boew-php

PHP variant of the Web Experience Toolkit (WET)
http://wet-boew-php.azurewebsites.net/demos-php/index.php
Other
24 stars 21 forks source link

[theme-gcwu-fegc] Banner enhancement #89

Open upsonp opened 10 years ago

upsonp commented 10 years ago

The code for the top banner needs to be updated for the theme-gcwu-fegc template to work properly. I think a similar approach as PHP variant 3.1 took will work here. Split theme specific sections out into respective theme specific php files to be include.

This is the current head code, works with theme-wet-boew: -- indicate lines to be removed, ++ indicate lines that need to be added.

<header role="banner">
<!-- HeaderStart -->

<div id="wb-bnr">
<div id="wb-bar">
<div class="container">
<div class="row">
--<section id="wb-lng" class="visible-md visible-lg">
<h2>Language selection</h2>
--<ul class="text-right">
--<li><a lang="fr" href="/wet-boew-php/dist-php/langselect/lang.php">Français</a></li>
--<li class="curr" >English&#32;<span>(current)</span>
--</li>
--</ul>
--</section>
<section class="wb-mb-links col-xs-12 visible-sm visible-xs" id="wb-glb-mn">
<h2>Menu</h2>
<ul class="pnl-btn list-inline text-right">
<li><a href="#mb-pnl" title="Menu" aria-controls="mb-pnl" class="overlay-lnk" role="button"><span class="glyphicon glyphicon-th-list"><span class="wb-inv">Menu</span></span></a></li>
</ul>
<div id="mb-pnl"></div>
</section>
</div>
</div>
</div>
<div class="container">
<div class="row">
<div id="wb-sttl" class="col-md-8">
<a href="/wet-boew-php/demos-php/index-en.php">
<object type="image/svg+xml" tabindex="-1" role="img" data="/theme-gcwu-fegc/assets/logo.svg" aria-label="Web Experience Toolkit"></object>
<span>PHP Variant</span>
</a>
</div>
--<section id="wb-srch" class="col-md-4 visible-md visible-lg"><h2>Search</h2><form action="#" method="post" role="search" class="form-inline">
<div class="form-group">
<label for="wb-srch-q">Search Website</label>
<input id="wb-srch-q" class="form-control" name="wb-srch-q" type="search" value="" size="27" maxlength="150"/>
</div>
<button type="submit" id="wb-srch-sub" class="btn btn-default" name="wb-srch-sub">Search</button>
</form>
--</section>
</div>
</div>
</div>

<!-- TODO: Add php variable for data-ajax-fetch file -->
<nav role="navigation" id="wb-sm" data-ajax-fetch="/wet-boew/ajax/sitemenu-en.html" data-trgt="mb-pnl" class="wb-menu visible-md visible-lg" typeof="SiteNavigationElement">
<div class="container nvbar"><h2>Site menu</h2>
<div class="row">
<ul class="list-inline menu">
<li><a href="/wet-boew/index-en.html">WET project</a></li>
<li><a href="https://github.com/wet-boew/wet-boew/wiki/Implementing-WET">Implement WET</a></li>
<li><a href="https://github.com/wet-boew/wet-boew/wiki/Contributor-guidelines">Contribute to WET</a></li>
</ul>
</div>
</div>
</nav>

<nav role="navigation" id="wb-bc" property="breadcrumb"><h2>Breadcrumb trail</h2><div class="container"><div class="row"><ol class="breadcrumb"><li><a href="/demos-php/index-en.php">Home</a></li><li>WET theme</li></ol></div></div></nav>
<!-- HeaderEnd -->

</header>

This is the code taken from http://wet-boew.github.io/themes-dist/theme-gcwu-fegc/index-en.html:

<header role="banner">
<div id="wb-bnr">
<div id="wb-bar">
<div class="container">
<div class="row">
++<object id="gcwu-sig" type="image/svg+xml" tabindex="-1" role="img" data="./assets/sig-en.svg" aria-label="Government of Canada"></object>
++<ul id="gc-bar" class="list-inline">
++<li><a href="http://www.canada.ca/en/index.html" rel="external">Canada.ca</a></li>
++<li><a href="http://www.canada.ca/en/services/index.html" rel="external">Services</a></li>
++<li><a href="http://www.canada.ca/en/gov/dept/index.html" rel="external">Departments</a></li>
++<li id="wb-lng"><h2>Language selection</h2>
++<ul class="list-inline">
++<li><a lang="fr" href="index-fr.html">English</a></li>
++</ul>
++</li>
++</ul>
<section class="wb-mb-links col-xs-12 visible-sm visible-xs" id="wb-glb-mn">
<h2>Menu</h2>
<ul class="pnl-btn list-inline text-right">
<li><a href="#mb-pnl" title="Menu" aria-controls="mb-pnl" class="overlay-lnk" role="button"><span class="glyphicon glyphicon-th-list"><span class="wb-inv">Menu</span></span></a></li>
</ul>
<div id="mb-pnl"></div>
</section>
</div>
</div>
</div>
<div class="container">
<div class="row">
++<div id="wb-sttl">
<a href="./index-en.html">
<span>Web Experience Toolkit</span>
</a>
++<object id="wmms" type="image/svg+xml" tabindex="-1" role="img" data="././assets/wmms.svg" aria-label="Symbol of the Government of Canada"></object>
</div>
++<section id="wb-srch" class="visible-md visible-lg">
<h2>Search</h2>
<form action="https://google.ca/search" method="get" role="search" class="form-inline">
<div class="form-group">
<label for="wb-srch-q">Search website</label>
<input id="wb-srch-q" class="form-control" name="q" type="search" value="" size="27" maxlength="150"/>
<input type="hidden" name="q" value="site:wet-boew.github.io OR site:github.com/wet-boew/"/>
</div>
<button type="submit" id="wb-srch-sub" class="btn btn-default">Search</button>
</form>
</section>
</div>
</div>
</div>
<nav role="navigation" id="wb-sm" data-ajax-fetch="./ajax/sitemenu-en.html" data-trgt="mb-pnl" class="wb-menu visible-md visible-lg" typeof="SiteNavigationElement">
<div class="container nvbar">
<h2>Site menu</h2>
<div class="row">
<ul class="list-inline menu">
<li><a href="./index-en.html">WET project</a></li>
<li><a href="http://wet-boew.github.io/wet-boew/docs/gs-cd/impl-en.html">Implement WET</a></li>
<li><a href="http://wet-boew.github.io/wet-boew/docs/gs-cd/contrib-en.html">Contribute to WET</a></li>
</ul>
</div>
</div>
</nav>
<nav role="navigation" id="wb-bc" property="breadcrumb">
<h2>You are here:</h2>
<div class="container">
<div class="row">
<ol class="breadcrumb">
<li>
<a href="./index-en.html">Home</a>
</li>
<li>GCWU theme</li>
</ol>
</div>
</div>
</nav>
</header>
crochefort commented 10 years ago

Is this for V3 or V4 ?

upsonp commented 10 years ago

It's for version 4