search

wet-boew / wet-boew-php

PHP variant of the Web Experience Toolkit (WET)
http://wet-boew-php.azurewebsites.net/demos-php/index.php
Other
24 stars 21 forks source link

Question about the title and theme-title #98

Open crochefort opened 10 years ago

crochefort commented 10 years ago

Can we invert them ?

Actually the theme_title is also the H1 and the breadcrumb title. The Page title is after the " - Department"

From a wording perspective the Theme title should be at the end because you can say that you selec the Theme for SSC

And when you are reading the code you see page title. and actually it's at the end of the windows title bar . So not perfect solution.

Quick example from : http://wet-boew.github.io/themes-dist/theme-gcwu-fegc/index-en.html

They have this : GCWU theme - Web Experience Toolkit

GCWU theme is also the H1 and in the breadcrumb. Web Experience Toolkit is there because it's at the website title!

What do you think?

upsonp commented 10 years ago

So instead of reading "GCWU theme - Web Experience Toolkit" it should read "Web Experience Toolkit - GCWU theme"?

crochefort commented 10 years ago

No we are just inversing the title on the variant. The main theme is correct.

Try it your self . Actually you have this 

$_PAGE['title_' . $_PAGE['lang1']] = $theme_title[$_SITE['wb_theme']]." - Web Experience Toolkit";
$theme_title = array( "theme-base" => "WET theme", "theme-gcwu-fegc" => "GCWU Theme");

This will result in that : GCWU Theme - Web Experience Toolkit

Should be Web Experience Toolkit - GCWU Theme

Imagine you put it in your site

$_PAGE['title_' . $_PAGE['lang1']] = $theme_title[$_SITE['wb_theme']]." - Spotlight on Science";
$theme_title = array( "theme-base" => "WET theme", "theme-gcwu-fegc" => "Bedford Institute of Oceanography");

Will Resulting Bedford Institute of Oceanography - Spotlight on Science

It should be Spotlight on Science - Bedford Institute of Oceanography

No?