search

wet-boew / wet-boew-styleguide

A style guide for the Web Experience Toolkit.
http://wet-boew.github.io/wet-boew-styleguide/index-en.html
36 stars 32 forks source link

Design guide: Replaced all HTML5 <header> elements with <div> elements in code/examples. #228

Closed EricDunsworth closed 9 years ago

pjackson28 commented 9 years ago

Why is this change being made? Doesn't the HTML5 spec permit header to be used this way?

LaurentGoderre commented 9 years ago

yes it does, this would make the outline less good

pjackson28 commented 9 years ago

Okay, then we should hold off on making this change as we don't want to weaken the outline (also would have introduced a markup change on people).

EricDunsworth commented 9 years ago

I personally just found it really strange for <header> elements to be used around headings in panels, and not under any other circumstances. From a consistency perspective, I don't see any value in only marking up <heading> elements around panels, and not anywhere else (like around every single section in content areas).

Btw Bootstrap's own panel examples also don't use <heading> elements in panels.

LaurentGoderre commented 9 years ago

Panels are usually self contained boxes therefore it totally make sense to use the header to identify that it's the header for the panel. Headers don't make sense in content but they do in panels