wet-boew / wet-boew-styleguide

A style guide for the Web Experience Toolkit.
http://wet-boew.github.io/wet-boew-styleguide/index-en.html
36 stars 32 forks source link

Form Validation - Fieldset horizontal rule perceptual break #236

Closed neoinsight closed 9 years ago

neoinsight commented 9 years ago

@thomasgohard In a heuristic evaluation of a department's WET form implementation, we noticed the horizontal rule below the Fieldset legend text visually separates the Fieldset legend from the fields below. In usability testing, we have seen this cause users to think a fieldset-type heading was not related to the fields below, but rather to the fields above it.

Would like to recommend that the fieldset's horizontal rule be moved ABOVE the fieldset label. Thus the rule will separate the fieldset from a previous set, rather than from the fields within the set. (see Gestalt Perceptual Principles...) This could wait for form usability testing, but have already seen it cause problems before, so prefer not to wait.

EXAMPLE: On Working Examples/Form validation, the code below causes the legend 'Contact Information' to be displayed with a horizontal rule below it, as shown in the attached image.

Contact information
![fieldset example wet](https://cloud.githubusercontent.com/assets/1855584/5549440/caecf2fe-8b58-11e4-9d86-33631b79f322.png)
thomasgohard commented 9 years ago

@neoinsight I agree. The rule should be above the heading text, not below. I'll make the change ASAP.

neoinsight commented 9 years ago

Terrific, thank you. I saw as well that the file attach is now displayed in the Form Validation example - good stuff, that will be helpful. Will you close this issue when you change it and submit a Pull or should I close it (need to learn the protocol). Merry Christmas!

thomasgohard commented 9 years ago

@neoinsight I'll close when I merge the fix. But don't hesitate to re-open if the fix doesn't work for you.

Merry Christmas to you too.