search

wet-boew / wet-boew-styleguide

A style guide for the Web Experience Toolkit.
http://wet-boew.github.io/wet-boew-styleguide/index-en.html
36 stars 32 forks source link

Breadcrumbs and Related Links in style guide broken #266

Closed kellerd closed 5 years ago

kellerd commented 8 years ago

Found a lot of Related Links that switch sections in the style guide, or the breadcrumbs in the style guide come up with 404 errors.

Example page: http://wet-boew.github.io/wet-boew-styleguide/v4/design/icons-en.html Related link to Accessibility guide is broken, breadcrumbs broken

Other examples of correct and broken links

Link found: http://wet-boew.github.io/wet-boew-styleguide/v4/wet-boew/design/index-en.html Should be: http://wet-boew.github.io/wet-boew-styleguide/v4/design/index-en.html

Link found:http://wet-boew.github.io/wet-boew-styleguide/v4/accessibility/design/icons-en.html Should be: http://wet-boew.github.io/wet-boew-styleguide/v4/design/icons-en.html

Link found:http://wet-boew.github.io/wet-boew-styleguide/v4/accessibility/images-en.html Should be: http://wet-boew.github.io/wet-boew-styleguide/v4/accessibility/requirements/images-en.html

Link found: http://wet-boew.github.io/wet-boew-styleguide/v4/wet-boew/index-en.html Should be: http://wet-boew.github.io/wet-boew-styleguide/v4/index-en.html

RobJohnston commented 7 years ago

Checked all these... With the re-write of the style guide, most of this has been fixed.

The only one still broken in this list is the link to the Accessibility guide on http://wet-boew.github.io/wet-boew-styleguide/v4/accessibility/requirements/images-en.html. The breadcrumb "Style guide" actually links to the accessibility guide.

ghost commented 7 years ago

@RobJohnston If you want I can do up a quick PR to fix this?

ghost commented 7 years ago

@RobJohnston Also should the french link be removed until translation of the accessibility guides are complete (if they are in the works)?

RobJohnston commented 7 years ago

Sure... I just had a few minutes free, so went looking issues to close.

Don't know about the second part.

ghost commented 7 years ago

I'll see about @cfarquharson input before I continue?

cfarquharson commented 7 years ago

I'm not sure who did the accessibility guide. It wasn't me. I would be great if it could be reworked and integrated into the guide. Currently it's in English only and could use some updating.

ghost commented 5 years ago

Closing as fixed by https://github.com/wet-boew/wet-boew-styleguide/issues/363 and https://github.com/wet-boew/wet-boew-styleguide/pull/364.