wet-boew / wet-boew-styleguide

A style guide for the Web Experience Toolkit.
http://wet-boew.github.io/wet-boew-styleguide/index-en.html
35 stars 32 forks source link

Breadcrumb: Fixed accessibility/visual layout issues. #338

Closed EricDunsworth closed 7 years ago

EricDunsworth commented 7 years ago

The wet-boew repo uses a "breadcrumbs" include, which contains the breadcrumb's basic code structure (i.e. nav, h2, div and ol elements) and references an include called "breadcrumbscontent" for list item content. All WET themes rely on wet-boew's "breadcrumbs" include and provide their own "breadcrumbscontent" includes.

Until now, the style guide was overriding the "breadcrumbs" include with a copy that contained div/ol elements and list item content... but it lacked nav/h2 elements. That setup resulted in accessibility/theming issues. This commit fixes them by renaming the style guide's "breadcrumbs" include to "breadcrumbscontent" and removing its div/ol elements (since wet-boew's "breadcrumbs" include will now bring them in).