search

wet-boew / wet-boew-styleguide

A style guide for the Web Experience Toolkit.
http://wet-boew.github.io/wet-boew-styleguide/index-en.html
35 stars 32 forks source link

Fix Font Awesome Icons #378

Closed ghost closed 5 years ago

ghost commented 5 years ago

All Icons Upgraded To v5

Also a shoutout to @estebandelaf for a bash script automating the process. See fontawesome4to5.sh. The script may need adjusting depending on OS. I had to make some changes for MacOS.

ghost commented 5 years ago

Went with <code><a href="https://fontawesome.com/start" class="text-danger">&lt;link rel="stylesheet" href="https://use.fontawesome.com/releases/[version]/css/all.css" integrity="sha384-[hash]" crossorigin="anonymous"&gt;</a></code>

Screen Shot 2019-04-17 at 6 32 07 PM

The red is darker than normal <code>, but I don't think we should be specifying a version as it can change, but also need to link to the page with latest cdn.

ghost commented 5 years ago

Could be rewritten too To use visit <a href="">Font Awesome</a> for the latest CDN code.

But someone would need to write it in French.

duboisp commented 5 years ago

What about:

English:

Consult the <a href="">Font Awesome</a> website for implementation instruction.

French:

Consulter le site web de <a href="" lang="en">Font Awesome</a> pour les instructions d'implémentation.
ghost commented 5 years ago

Perfect, we'll submit soon.

ghost commented 5 years ago

Fixed.

ghost commented 5 years ago

Merging now that the requested change was made.