wet-boew / wet-boew-styleguide

A style guide for the Web Experience Toolkit.
http://wet-boew.github.io/wet-boew-styleguide/index-en.html
35 stars 32 forks source link

Update most HTTP links to HTTPS #380

Closed EricDunsworth closed 5 years ago

EricDunsworth commented 5 years ago

Notes:

ghost commented 5 years ago

Some other update?

This way it directs the user to the correct bootstrap version?

EricDunsworth commented 5 years ago

@thekodester I agree with the idea of those kinds of changes, but don't feel like they would be appropriate as a part of this PR. Its sole purpose was to update the protocol on all pre-existing HTTP links to sites that support HTTPS.

IMO changing link destinations in other ways would go beyond this PR's scope. Also, the style guide's content is probably in need of much bigger updates than just updating Bootstrap link destinations. Various other links might potentially be broken and/or pointing to sites that no longer exist.

ghost commented 5 years ago

@EricDunsworth Fair point. I have update some of the links when I did the switch to jekyll. I'll maybe open an issue for that.

Otherwise I see no issue with this PR, so I we'll merge it.

duboisp commented 5 years ago

👍