Open rubinahaddad opened 10 years ago
We do not include any of the JavaScript from Bootstrap nor has any of it been reviewed for accessibility/usability. So the dropdown buttons, which are dependent upon Bootstrap JavaScript, should not be included in the guide, unless you are discouraging its usage.
As for IE8, it is still supported for now but support could be dropped in the next few months. File IE8 issues on the issue tracker like any other issues.
Agree with limiting the variability around buttons as much as necessary - seems like there's a lot of button styles in https://github.com/wet-boew/wet-boew-styleguide/issues/26#issuecomment-38597163, let alone size and other options.
Wow. There's sure are a lot of variations for the buttons. Too many. Agreed.
Removing options may not be easy though as they're part of Bootstrap, which we're importing as a whole. I'll have to check how to best do that. It may necessary to replace options we don't want to support with the default options (e.g., making button size small be the same as button size default).
Don't override them as some components require the different variations (e.g., the mobile panel button needs btn-xs). Overriding will break things. Instead cover when to use and not to use in the styleguide.
From the HE: https://github.com/wet-boew/wet-boew-styleguide/issues/26
From the HEs all the reviewers were troubled by the fact that having quite so many different options for buttons was not a good strategy for developing the basis for an enterprise solution. Using more than a few of them creates inconsistencies in the product. There need to be limited opportunities for creative licence for the individual page developer – either because there are few button options, or because there is very clear guidance.
The following were recommended to be removed:
@thomasgohard There were many IE 8 bugs noted - Does WET 4 support IE8?
I'm logging this here as i think this should be discussed: @pjackson28 @cfarquharson @thomasgohard @laurawesley @pcwsmith @masterbee