Charts and Graphs and GeoMap Bug

upsonp commented 11 years ago

I've come across an issue that's reproducible in Internet Explorer 9, Opera, Safair and Firefox running on Windows 7

When I have a page that uses both the Graph and a Geomap WET extensions, the table the graph is generated from can not be made visible. It works as expected in Chrome. Note the Expandable area containing the "Instructions: Map Navigation" works fine in all browsers.

chartgeomapissue

When I removed GeoMap from the page in the screenshot, the expandable area for the Chart worked fine.

pjackson28 commented 11 years ago

@duboisp @jolevesq Could you please look into this? Something in either Geomap or Charts is interfering with the loading of the details/summary polyfill in this case. Note with how WET works, it enhances from the bottom up so Geomap gets executed first followed by Charts. What may be complicating the issue is the deferred loading of the details/summary that each does which could be colliding with one another.

Another interesting test would be to use either of the plugins on a page with a regular details/summary in the markup and see if that has conflicts as well.

upsonp commented 11 years ago

I created a test page and tested with a details section. Once with the Chart and graph, Once with the Geomap

Passed when detail section combined with Chart and Graph

Failed in IE 9 with the Geomap enabled.

chartgeomapissue_001

Source

<!DOCTYPE html>
<!--[if IE 7]><html lang="en" class="no-js ie7"><![endif]-->
<!--[if IE 8]><html lang="en" class="no-js ie8"><![endif]-->
<!--[if gt IE 8]><!-->
<html lang="en" class="no-js">
<!--<![endif]-->
<head>
<meta charset="utf-8" />
<!-- Web Experience Toolkit (WET) / Boîte à outils de l'expérience Web (BOEW)
wet-boew.github.io/wet-boew/License-eng.txt / wet-boew.github.io/wet-boew/Licence-fra.txt -->
<title>CAN-EWLAT, ?LE BRYON, QC</title>

<link rel="shortcut icon" href="/wet-boew/dist/theme-gcwu-fegc/images/favicon.ico" />
<meta name="dcterms.title" title="ISO639-2" content="CAN-EWLAT, ?LE BRYON, QC" />
<meta name="dcterms.language" title="ISO639-2" content="eng" />
<meta name="dcterms.issued" title="W3CDTF" content="2011-11-01" />
<meta name="dcterms.modified" title="W3CDTF" content="2013-05-09" />

<meta name="viewport" content="width=device-width, initial-scale=1" /><!--custom metadata-->
<!--end of custom metadata-->

<!-- CSS Grid System begins / Début du système de grille de CSS -->
<!--[if lte IE 8]>
<script src="/wet-boew/dist/js/jquery-ie.min.js"></script>
<script src="/wet-boew/dist/js/polyfills/html5shiv-min.js"></script>
<link rel="stylesheet" href="/wet-boew/dist/grids/css/util-ie-min.css" />
<link rel="stylesheet" href="/wet-boew/dist/js/css/pe-ap-ie-min.css" />
<link rel="stylesheet" href="/wet-boew/dist/theme-gcwu-fegc/css/theme-ie-min.css" />
<noscript><link rel="stylesheet" href="/wet-boew/dist/theme-gcwu-fegc/css/theme-ns-ie-min.css" /></noscript>
<![endif]-->
<!--[if gt IE 8]><!-->
<script src="/wet-boew/dist/js/jquery.min.js"></script>
<link rel="stylesheet" href="/wet-boew/dist/grids/css/util-min.css" />
<link rel="stylesheet" href="/wet-boew/dist/js/css/pe-ap-min.css" />
<link rel="stylesheet" href="/wet-boew/dist/theme-gcwu-fegc/css/theme-min.css" />
<noscript><link rel="stylesheet" href="/wet-boew/dist/theme-gcwu-fegc/css/theme-ns-min.css" /></noscript>
<!--<![endif]-->
<!-- CSS Grid System ends / Fin du système de grille de CSS -->
<!-- WET scripts/CSS end / Fin des scripts/CSS de la BOEW -->

<!-- Custom CSS Start -->
<link rel="stylesheet" href="/includes/css/bio.css" media="screen" type="text/css" />

<!--custom css-->
<!--end of custom css-->

<!-- Custom CSS End -->
</head>

<body><div id="wb-body-sec">
<div id="wb-skip">
<ul id="wb-tphp">
<li id="wb-skip1"><a href="#wb-cont">Skip to main content</a></li>
<li id="wb-skip2"><a href="#wb-nav">Skip to secondary menu</a></li>
</ul>
</div>

<div id="wb-head"><div id="wb-head-in"><header>

<!-- HeaderStart -->
<nav role="navigation"><div id="gcwu-gcnb"><h2>Government of Canada navigation bar</h2>
<div id="gcwu-gcnb-in"><div id="gcwu-gcnb-fip">
<div id="gcwu-sig"><div id="gcwu-sig-in"><object data="/wet-boew/dist/theme-gcwu-fegc/images/sig-eng.svg" role="img" tabindex="-1" aria-label="Government of Canada" type="image/svg+xml"><img src="/wet-boew/dist/theme-gcwu-fegc/images/sig-eng.png" alt="Government of Canada" /></object></div></div>
<ul>
<li id="gcwu-gcnb1"><a rel="external" href="http://www.canada.gc.ca/menu-eng.html">Canada.gc.ca</a></li>
<li id="gcwu-gcnb2"><a rel="external" href="http://www.servicecanada.gc.ca/eng/home.shtml">Services</a></li>
<li id="gcwu-gcnb3"><a rel="external" href="http://www.canada.gc.ca/aboutgov-ausujetgouv/depts/menu-eng.html">Departments</a></li>
<li id="gcwu-gcnb-lang"><a href="/wet-boew/dist-php/langselect/lang.php" lang="fr">Français</a></li></ul>
</div></div></div></nav>

<div id="gcwu-bnr" role="banner"><div id="gcwu-bnr-in">
<div id="gcwu-wmms"><div id="gcwu-wmms-in"><object data="/wet-boew/dist/theme-gcwu-fegc/images/wmms.svg" role="img" tabindex="-1" aria-label="Symbol of the Government of Canada" type="image/svg+xml"><img src="/wet-boew/dist/theme-gcwu-fegc/images/wmms.png" alt="Symbol of the Government of Canada" /></object></div></div>

<div id="gcwu-title"><p id="gcwu-title-in"><a href="/index-eng.php">Bedford Institute of Oceanography</a></p></div>
<section role="search"><div id="gcwu-srchbx"><h2>Search</h2><form action="#" method="post"><div id="gcwu-srchbx-in">
<label for="gcwu-srch">Search Web site</label><input id="gcwu-srch" name="gcwu-srch" type="search" value="" size="27" maxlength="150" />
<input id="gcwu-srch-submit" name="gcwu-srch-submit" type="submit" value="Search" />
</div></form></div></section></div></div>

<nav role="navigation">
<div id="gcwu-psnb"><h2>Site menu</h2><div id="gcwu-psnb-in"><div class="wet-boew-menubar mb-mega"><div><ul class="mb-menu">
<li><section><h3><a href="#" title="BIO">BIO</a></h3>
<div class="mb-sm"><div class="span-2"><section><h4><a href="/index-eng.php" title="Bedford Institute of Oceanography">Bedford Institute of Oceanography</a></h4>
<ul><li><a href="/general-generales/about-sujet-eng.php" title="About BIO">About BIO</a></li>
<li><a href="/other-autres/history-historique-eng.php" title="A Brief History of BIO">A Brief History of BIO</a></li>
<li><a href="/general-generales/contact-contactez-eng.php" title="Contact BIO">Contact BIO</a></li>
<li><a href="/general-generales/directions-eng.php" title="How to Find BIO">How to Find BIO</a></li>
<li><a href="/general-generales/events-activites-eng.php" title="Upcoming Events">Upcoming Events</a></li>
</ul></section>
<section><h4>Info for Clients</h4>
<ul><li><a href="/info/advisory-consultatifs-eng.php" title="Advisory Activities">Advisory Activities</a></li>
<li><a href="/info/collaborations/index-eng.php" title="Collaborations">Collaborations</a><ul><li><a href="/info/collaborations/partnerships-partenariat-eng.php" title="Research Partnerships">Research Partnerships</a></li>
<li><a href="/info/collaborations/universities-universites-eng.php" title="Universities">Universities</a></li>
</ul></li>
<li><a href="http://www.dfo-mpo.gc.ca/science/coe-cde/index-eng.htm" title="Centres of Expertise">Centres of Expertise</a></li>
<li><a href="/info/publications-eng.php" title="BIO Publications">BIO Publications</a></li>
</ul></section>
</div>
<div class="span-2"><section><h4>Outreach</h4>
<ul><li><a href="/outreach-depassez/careers-carrieres-eng.php" title="Careers at BIO">Careers at BIO</a></li>
<li><a href="/outreach-depassez/tours-visites-eng.php" title="Guided Tours">Guided Tours</a></li>
<li><a href="/outreach-depassez/pavilion-pavillon-eng.php" title="Sea Pavilion">Sea Pavilion</a></li>
</ul></section>
<section><h4>Facilities</h4>
<ul><li><a href="/facilities-installations/buildings-immeubles-eng.php" title="Buildings">Buildings</a></li>
<li><a href="/facilities-installations/gift-cadeux-eng.php" title="Gift Shop">Gift Shop</a></li>
<li><a href="http://www.dfo-mpo.gc.ca/libraries-bibliotheques/maritimes-eng.htm#bedford" title="Library">Library</a></li>
<li><a href="/facilities-installations/vessels-navires/vessels-navires-eng.php" title="Research Vessels">Research Vessels</a><ul><li><a href="/facilities-installations/vessels-navires/ccgs-hudson-ngcc-eng.php" title="CGGS Hudson">CGGS Hudson</a></li>
<li><a href="/facilities-installations/vessels-navires/ccgs-matthew-ngcc-eng.php" title="CCG Matthew">CCG Matthew</a></li>
<li><a href="/facilities-installations/vessels-navires/ccgs-needler-ngcc-eng.php" title="CCGS Needler">CCGS Needler</a></li>
</ul></li>
</ul></section>
</div>
<div class="clear"></div>

<div class="mb-main-link"><a href="/index-eng.php" title="Bedford Institute of Oceanography - Main Page">Bedford Institute of Oceanography - Main Page</a></div>
</div></section>
</li>
<li><section><h3><a href="#" title="Science">Science</a></h3>
<div class="mb-sm"><div class="span-2"><section><h4><a href="/science/data-donnees/index-eng.php" title="Data and Products">Data and Products</a></h4>
<ul><li><a href="/science/data-donnees/base/index-eng.php" title="Oceanographic Databases">Oceanographic Databases</a></li>
<li><a href="/science/data-donnees/acon-eng.php" title="ACON">ACON</a></li>
<li><a href="/science/research-recherche/ocean/ice-glace/data-donnees-eng.php" title="Sea Ice Studies - Data">Sea Ice Studies</a></li>
</ul></section>
<section><h4><a href="/science/research-recherche/index-eng.php" title="Research">Research</a></h4>
<ul><li><a href="/science/research-recherche/ocean/index-eng.php" title="Ocean Sciences">Ocean Sciences</a><ul><li><a href="/science/research-recherche/ocean/variability-variabilite/variability-variabilite-eng.php" title="Ocean Climate and Variability">Ocean Climate and Variability</a></li>
<li><a href="/science/research-recherche/ocean/modelling-modelisation/coastalembayments-cotieresdesbaies/index-eng.php" title="Coastal Embayments">Coastal Embayments</a></li>
<li><a href="/science/research-recherche/ocean/ice-glace/index-eng.php" title="Sea Ice">Sea Ice</a></li>
<li><a href="/science/research-recherche/ocean/webtide/index-eng.php" title="WebTide Tidal Prediction Model">WebTide Tidal Prediction Model</a></li>
<li><a href="/science/research-recherche/ocean/webdrogue/index-eng.php" title="WebDrogue Drift Prediction Model">WebDrogue Drift Prediction Model</a></li>
</ul></li>
<li><a href="/science/research-recherche/fisheries-pecheries/index-eng.php" title="Fisheries and Aquaculture">Fisheries and Aquaculture</a><ul><li><a href="/science/research-recherche/fisheries-pecheries/managed-gere/index-eng.php" title="Managed Fisheries">Managed Fisheries</a></li>
<li><a href="/science/research-recherche/fisheries-pecheries/sharks-requins/index-eng.php" title="Canadian Shark Research Laboratory">Canadian Shark Research Laboratory</a></li>
</ul></li>
<li><a href="/science/research-recherche/ecosystem-ecosysteme/index-eng.php" title="Ecosystem Research">Ecosystem Research</a><ul><li><a href="/science/research-recherche/ecosystem-ecosysteme/genetics-genetique/genetics-genetique-eng.php" title="Biotechnology &amp; Genomics (Genetics)">Biotechnology &amp; Genomics (Genetics)</a></li>
<li><a href="/science/research-recherche/ecosystem-ecosysteme/ocg-gco-eng.php" title="Organic Chemistry Group">Organic Chemistry Group</a></li>
</ul></li>
<li><a href="http://www.nrcan.gc.ca/earth-sciences/home" title="Geological Survey of Canada">Geological Survey of Canada</a></li>
</ul></section>
</div>
<div class="span-2"><section><h4><a href="/science/monitoring-monitorage/index-eng.php" title="Monitoring">Monitoring</a></h4>
<ul><li><a href="/science/monitoring-monitorage/azmp-pmza-eng.php" title="Atlantic Zone Monitoring Program">Atlantic Zone Monitoring Program</a></li>
<li><a href="/science/monitoring-monitorage/azomp-pmzao/azomp-pmzao-eng.php" title="Atlantic Zone Off-Shelf Monitoring Program ">Atlantic Zone Off-Shelf Monitoring Program </a></li>
<li><a href="/science/monitoring-monitorage/bbmp-pobb/bbmp-pobb-eng.php" title="Bedford Basin Monitoring Program">Bedford Basin Monitoring Program</a></li>
<li><a href="/science/monitoring-monitorage/mwqmp-psqem-eng.php" title="Marine Water Quality Monitoring Program">Marine Water Quality Monitoring Program</a></li>
</ul></section>
<section><h4><a href="/science/newtech-technouvelles/index-eng.php" title="New Technologies">New Technologies</a></h4>
<ul><li><a href="/science/newtech-technouvelles/sensing-teledetection/index-eng.php" title="Operational Remote Sensing">Operational Remote Sensing</a></li>
<li><a href="/science/newtech-technouvelles/seahorse/index-eng.php" title="Seahorse">Seahorse</a><ul><li><a href="/science/newtech-technouvelles/seahorse/basin-bassin-eng.php" title="Bedford Basin Deployment">Bedford Basin Deployment</a></li>
<li><a href="/science/newtech-technouvelles/seahorse/station-eng.php" title="Station 2 Deployment">Station 2 Deployment</a></li>
</ul></li>
<li><a href="/science/newtech-technouvelles/observatory-observatoire-eng.php" title="Real-Time Arctic Ocean Observatory">Real-Time Arctic Ocean Observatory</a></li>
</ul></section>
</div>
<div class="clear"></div>

</div></section>
</li>
</ul>
<!--<div id="gcwu-psnb">
  <h2><span>Site</span> menu</h2>
  <div id="gcwu-psnb-in">
    <div class="wet-boew-menubar mb-mega">
      <div>
        <ul class="mb-menu" data-ajax-replace="/wet/includes/menu-eng.txt">
          <li>
            <h3><a href="/wet/otw-am/index-eng.htm">On the Water</a></h3>
          </li>
          <li>
            <h3><a href="/wet/fm-gp/index-eng.htm">Fisheries</a></h3>
          </li>
          <li>
            <h3><a href="/wet/ecosystems/index-eng.htm">Ecosystems</a></h3>
          </li>
          <li>
            <h3><a href="/wet/aquaculture/index-eng.htm">Aquaculture</a></h3>
          </li>
          <li>
            <h3><a href="/wet/species-especes/index-eng.htm">Species</a></h3>
          </li>
          <li>
            <h3><a href="/wet/research-recherche/index-eng.htm">Scientific Research</a></h3>
          </li>
          <li>
            <h3><a href="/wet/regions/index-eng.htm">Regions</a></h3>
          </li>
        </ul>
      </div>
    </div>
  </div>
</div>--></div></div></div></div>
<div id="gcwu-bc"><h2>Breadcrumb trail</h2><div id="gcwu-bc-in">
<ol>
<li><a href="/index-eng.php">BIO Home</a></li><li><a href="/science/data-donnees/index-eng.php">Data and Products</a></li><li>CAN-EWLAT, ?LE BRYON, QC</li></ol>
</div></div></nav><!-- HeaderEnd -->

</header></div></div>
<div id="wb-core"><div id="wb-core-in" class="equalize">
<div id="wb-main" role="main"><div id="wb-main-in">
<!-- MainContentStart -->
<h1 id="wb-cont">CAN-EWLAT, ?LE BRYON, QC</h1>

<!-- Main content start -->

<details class="border-all">
    <summary>View code</summary>
    <pre>This is a test to see if the expandable area works with the Geomap extension</pre>
</details>

<!-- <table class="wet-boew-charts wb-charts-bar">
    <caption class="wb-invisible">Allowances for QC, ?LE BRYON station 612</caption>
    <thead>
        <tr>
            <td></td>
            <th>2000</th>
<th>2010</th>
<th>2020</th>
<th>2030</th>
<th>2040</th>
<th>2050</th>
<th>2060</th>
<th>2070</th>
<th>2080</th>
<th>2090</th>
<th>2100</th>
        </tr>
    </thead>
    <tbody>
        <tr>
<th>Allowance in CM</th>
<td>4</td>
<td>9</td>
<td>16</td>
<td>21</td>
<td>27</td>
<td>35</td>
<td>45</td>
<td>56</td>
<td>70</td>
<td>85</td>
<td>103</td>
</tr>
    </tbody>
</table>-->

<div class="clear"></div>

<div class="span-3">
    <div class="wet-boew-geomap position scaleline tab" 
        data-wet-boew='{ 
            "layersFile": "data/config-en.js", 
            "tables": [{ 
                "id": "SCHLocations", 
                "zoom": true,
                "tab": true,
                "datatable": true,
                "style": { 
                    "type": "symbol",
                    "init": { "pointRadius": "5", "strokeColor":"#000", "fillColor":"#F00" },
                    "select": { "pointRadius": "5", "strokeColor":"#000", "fillColor":"#0FF"}
                }
            }]    
        }'>
    </div>  
</div>
<!-- Insert Layer Data -->
<div class="wet-boew-geomap-layers span-3 wb-invisible"><section>
    <h2>Map Layers</h2>
    <table id="SCHLocations" class="table-simplify width-100" aria-label="SCH Locations">
        <caption>SCH Locations</caption>
        <thead>
            <tr>
                <th>Location</th>
                <th>Station</th>
            </tr>
        </thead>
        <tbody>
        <tr data-geometry="POINT (-61.508722, 47.784888)" data-type="wkt">
<td>?LE BRYON</td>
<td>612</td>
</tr>
        </tbody>
    </table>
</section>
</div>
<div class="span-3">
<p>Download the PDF for <a target="_blank" href="data/pdf/all_locations.pdf">All Locations</a></p>

<p>Download the PDF for <a target="_blank" href="data/pdf/North Sydney_Allowances.pdf">North Sydney</a></p><p>Download <a href="downloadStation.php?type=SCH&amp;stat=-1&amp;statname=all_sch_allowances">All station data</a></p>
<p>Download <a href="downloadStation.php?type=SCH&amp;stat=612&amp;statname=North Sydney">North Sydney station data</a></p>
</div>

<div class="clear"></div><!-- MainContentEnd -->
<dl id="gcwu-date-mod" role="contentinfo">
<dt>Date modified:</dt><dd><span><time>2013-05-09</time></span></dd>
</dl>
<div class="clear"></div>
</div></div>
<div id="wb-sec"><div id="wb-sec-in"><nav role="navigation"><h2 id="wb-nav">Secondary menu</h2>
<div class="wb-sec-def">
<!-- SecNavStart -->

<section>
    <section>
        <h3 class="top-section"><a href="/science/data-donnees/can-ewlat/index-eng.php" title="Canadian Extreme Water Level Adapation Tool (CAN-EWLAT)">Canadian Extreme Water Level Adapation Tool (CAN-EWLAT)</a></h3>
        <div class="mb-sm">
            <ul>
            </ul>
        </div>
    </section>
</section>
<!-- SecNavEnd -->
</div>
</nav></div></div>
</div></div>

<div id="wb-foot"><div id="wb-foot-in"><footer><h2>Footer</h2>
<!-- FooterStart -->
<nav role="navigation"><div id="gcwu-sft"><h3>Site footer</h3><div id="gcwu-sft-in">
<div id="gcwu-tctr">
<ul>
<li class="gcwu-tc"><a href="http://www.canada.gc.ca/importantnotices.html" rel="license">Terms and conditions</a></li>
<li class="gcwu-tr"><a href="http://www.servicecanada.gc.ca/eng/common/disclosure.shtml">Transparency</a></li>
</ul>
</div>
<div class="clear"></div>
<div class="span-2"><div class="gcwu-col-head"><a href="/general-generales/about-sujet-eng.php">About us</a></div><ul>
<li><a href="/general-generales/about-sujet-eng.php#departments">Our Mission</a></li>
<li><a href="/info/publications-eng.php">BIO Publications</a></li>
<li><a href="/outreach-depassez/careers-carrieres-eng.php">Careers</a></li>
</ul></div><div class="span-2"><div class="gcwu-col-head"><a href="#">News</a></div><!--<ul>
</ul>--></div><div class="span-2"><div class="gcwu-col-head"><a href="/general-generales/contact-contactez-eng.php">Contact us</a></div><address>
<ul>
    <li><a href="mailTo:WebmasterBIO-IOB@dfo-mpo.gc.ca">BIO Webmaster</a></li>
</ul>
</address></div><div class="span-2"><div class="gcwu-col-head"><a href="#">Stay connected</a></div><!--<ul>
<li><a rel="external" href="#">YouTube</a></li>
<li><a rel="external" href="#">Twitter</a></li>
<li><a href="#">Feeds</a></li>
</ul>--></div></div></div></nav>

<nav role="navigation"><div id="gcwu-gcft"><h3>Government of Canada footer</h3><div id="gcwu-gcft-in"><div id="gcwu-gcft-fip">
<ul>
<li><a rel="external" href="http://healthycanadians.gc.ca/index-eng.php"><span>Health</span><br />healthycanadians.gc.ca</a></li>
<li><a rel="external" href="http://www.voyage.gc.ca/index-eng.asp"><span>Travel</span><br />travel.gc.ca</a></li>
<li><a rel="external" href="http://www.servicecanada.gc.ca/eng/home.shtml"><span>Service Canada</span><br />servicecanada.gc.ca</a></li>
<li><a rel="external" href="http://www.jobbank.gc.ca/intro-eng.aspx"><span>Jobs</span><br />jobbank.gc.ca</a></li>
<li><a rel="external" href="http://actionplan.gc.ca/en"><span>Economy</span><br />actionplan.gc.ca</a></li>
<li id="gcwu-gcft-ca"><div><a rel="external" href="http://www.canada.gc.ca/menu-eng.html">Canada.gc.ca</a></div></li>
</ul>
</div></div></div></nav>
<!-- FooterEnd -->
</footer>

</div></div></div>

<!-- ScriptsStart -->
<script src="/wet-boew/dist/js/settings.js"></script>
<!--[if lte IE 8]>
<script src="/wet-boew/dist/theme-gcwu-fegc/js/theme-ie-min.js"></script>
<script src="/wet-boew/dist/js/pe-ap-ie-min.js"></script>
<script src="/wet-boew/dist/js/jquerymobile/jquery.mobile-ie.min.js"></script>
<![endif]-->
<!--[if gt IE 8]><!-->
<script src="/wet-boew/dist/theme-gcwu-fegc/js/theme-min.js"></script>
<script src="/wet-boew/dist/js/pe-ap-min.js"></script>
<script src="/wet-boew/dist/js/jquerymobile/jquery.mobile.min.js"></script>
<!--<![endif]-->
<!-- ScriptsEnd -->

<!-- CustomScriptsStart -->
<!-- CustomScriptsEnd -->
</body>
</html>

upsonp commented 11 years ago

For anyone having a similar issue, As a work around I used the wb-charts-noencapsulation-true on the table tag for my Graphs data table. The data table doesn't get hidden so there's no issue with no being able to expand the hidden section.

<table class="wet-boew-charts wb-charts-bar wb-charts-height-200 wb-charts-noencapsulation-true">

duboisp commented 11 years ago

Can the geomap enhance only the details element in his scope?

    _pe.polyfills.enhance('detailssummary', document.getElementsByTagName('details'));

https://github.com/wet-boew/wet-boew/blob/master/src/js/workers/geomap.js#L1278

jolevesq commented 11 years ago

@duboisp you are right, I can use _pe.polyfills.enhance('detailssummary', document.getElementsByClassName('wet-boew-geomap-detail')); to get only the details I need to enhance.

duboisp commented 11 years ago

@jolevesq I worry about a possible similar bug when 2 geomap instance co-exist on the same page.

What do you think if you enhance only the details/summary element that is created inside the instruction at https://github.com/wet-boew/wet-boew/blob/master/src/js/workers/geomap.js#L1277 ?

jolevesq commented 11 years ago

@duboisp When there 2 instances the detail summary works but there is a lot of other problems. I will have to modify the plug in a little bit to be able to put more then one instance on a page.

duboisp commented 11 years ago

a lot of other problems.

That was something I suspected when I looked at the geomap plugin code.

I will have to modify the plug in a little bit to be able to put more then one instance on a page.

I think that should be tracked in a new issue

pjackson28 commented 11 years ago

Has the issue been addressed in the latest code? Can it be closed?

duboisp commented 11 years ago

@pjackson28 I looked in the geomap source code and the issue has been addressed in the latest code. This issue can be closed.

Cheers

:smiley:

Quick summary

The issue was : https://github.com/wet-boew/wet-boew/blob/29be046ec53244b93d3fbca583c03088803b5682/src/js/workers/geomap.js#L1278

_pe.polyfills.enhance('detailssummary', document.getElementsByTagName('details'));

it's now fixed with: https://github.com/wet-boew/wet-boew/blob/master/src/js/workers/geomap.js#L1659

_pe.polyfills.enhance('detailssummary', _pe.main.find('#geomap-details-' + geomap.uniqueid));

https://github.com/wet-boew/wet-boew/blob/master/src/js/workers/geomap.js#L1757

_pe.polyfills.enhance('detailssummary', _pe.main.find('.geomap-legend' + geomap.uniqueid));

wet-boew / wet-boew

Charts and Graphs and GeoMap Bug #2274