search

wet-boew / wet-boew

Web Experience Toolkit (WET): Open source code library for building innovative websites that are accessible, usable, interoperable, mobile-friendly and multilingual. This collaborative open source project is led by the Government of Canada.
https://wet-boew.github.io/wet-boew/index-en.html
Other
1.61k stars 661 forks source link

Force nav-current-nocss #3993

Closed gobyrne closed 10 years ago

gobyrne commented 10 years ago

I'm required to make the menus on my divisions site match the ones for the rest of my sector. I'm close, but am having trouble with the nav-current classes. The sector site uses the nav-current-nocss class on the mega menu, but mine defaults to the nav-current class.

The result is that the "earth sciences" tab is dark on my page, but hot theirs. Is there a way to make them match? Can I force wet to apply nav-current-nocss instead of nav-current?

Thanks, here are some links if you want to look.

My (division's) development site http://webappd.geod.nrcan.gc.ca/geod/

Sector site http://www.nrcan.gc.ca/earth-sciences/geomatics/geodetic-reference-systems/10781

nschonni commented 10 years ago

The public site looks like it is running a mix of several WET releases on Drupal. The main files are 3.1.3 but the theme files are 3.0.6 and have a git merge message in the middle of the file. You might need to file an issue on https://github.com/wet-boew/wet-boew-drupal

pjackson28 commented 10 years ago

@gobyrne In WET v3.1, you could apply the "nav-current-nocss" class to the link to prevent the nav-current link from being applied. That is likely what your sector is doing.

gobyrne commented 10 years ago

@pjackson28 Thanks, but the nav-current class gets applied anyway and I end up with both classes on the link. (and it still appears dark blue)

pjackson28 commented 10 years ago

@gobyrne Figured it out, it is something in their v3.0.6 theme JS file that is no longer supported in v3.1. They also have a lot of issues with their CSS and JS files, including what looks like the remnants of Git merge conflicts in theme-min.css. The practice of disabling the menu bar colour is very much discouraged and is no longer supported for usability reasons but if you must do it for now then you would need to override with CSS,

Note that support for v3.0.x will be dropped once v4.0 is released in a couple of months.

gobyrne commented 10 years ago

Ok, thanks a lot. I'll leave as is and try to bring it to their attention.