Input type="date" polyfill (date picker): Setting "min" as future date causes picker to open up at max date

[WalidBounouar]

Hi,

I want to set the "min" attribute as a future date, but doing so causes the picker to open at the max date (if not set, opens at year 2100 which I believe is default max). However, the dates are disabled correctly if you navigate to them.

This happens only on some browsers. The native chrome picker is fine. I encounter the issue on Firefox 52.5 and IE 11.

Here’s code when inspecting page and screenshots. <input id="frmCCI-completion_date" name="frmCCI-completion_date" min="2018-01-11" size="10" type="date" class="form-control" />

I believe we are using wet v4.0.26 where I am.

I looked in issues and did not find the same problem flagged before. Do you have an idea on what the problem is and how to fix it?

Thanks

[ghost]

I was able to reproduce with latest version of WET on Safari also (using the polyfill). When MIN is future dated the calendar opens in the year 2100.

[ghost]

Seem to be related to the following if statement in the polyfill:

if ( today >= state.minDate && today <= state.maxDate ) {
 initDate = today;
} else {
 initDate = state.maxDate;
}

Code can be found at datepicker.js#L120

[WalidBounouar]

Do you have an idea when this could be fixed? Would it be included in a potential v4.0.28 release or could it be added to v4.0.27?

[duboisp]

@WalidBounouar we can't provide a time estimate of when this issue would be fixed. However, you or someone else can submit a PR with a fix. The submission date of that PR with the necessary time to review it and having the contributor to fix any-reported issue would determinate which version of WET it will be included.

FYI - The version 4.0.27 is already released.

[ghost]

I don't mind submitting the PR. Do you think we can just change it too:

if ( today >= state.minDate && today <= state.maxDate ) {
 initDate = today;
} else {
 initDate = state.minDate; ---> FROM MAX TOO MIN?
}

[LaurentGoderre]

@duboisp @kodecount the calendar polyfill has unit tests. A failing unit test need to be created before the fix.

[WalidBounouar]

I am in talks with my superiors to check if I can take time to find a fix and submit a PR. I will keep tabs on this issue in case somebody else submits a fix (and unit testing). I'm new to this so I would also be unable to provide a time frame.

[WalidBounouar]

We decided to use a workaround where I am, so I won't be able to find a fix. I will still follow the progress if this issue. Thanks

[duboisp]

The behavior need to be conform to the HTML 5.3 spec.

• https://www.w3.org/TR/html53/sec-forms.html#date-state-typedate
• https://www.w3.org/TR/html53/sec-forms.html#the-min-and-max-attributes
• https://www.w3.org/TR/html53/rendering.html#the-input-element-as-domain-specific-widgets

I quickly reviewed and I didn't saw a mention about the default behavior when opening with a min date that is in the future.

Next step would be:

• How that use case is implemented in the browser that support it?
• Is there some UX research about that use case?

[ghost]

FireFox v58: opens the calendar in the current month. Chrome v68: opens the calendar based on the minimum set. jQuery Date Picker: opens the calendar based on the minimum set.

[LaurentGoderre]

The minimum date should be the right behavior.

[ghost]

Any documents on the unit test you want or is that just a working example?

[LaurentGoderre]

basically there should be two unit tests for when the minimum date is in the future and when the maximum date is in the past that resembles this one:

https://github.com/wet-boew/wet-boew/blob/master/src/polyfills/datepicker/test.js#L477-L499

[WalidBounouar]

Hi, I would like to know if this issue number is sufficient to track progress on this bug? I don't know if you have another bug tracking system at Treasury Board.

We would like to be able to see when this is fixed so that we can move to a new release of WET.

[duboisp]

@WalidBounouar yes this issue number should be sufficient to track progress on this bug.

If having this issue fixed matter for you or for your organisation, the best option will be to spent your time on resolving it and submitting a PR. If you can work on a fix and need help, contact me and we can have a quick chat. You can find my info on GCconnex, on GCcollab or you can reach me via twitter.

[WalidBounouar]

@duboisp thanks for the speedy reply.

If I can get the time to find a fix for this, I'll mention it here. You're contact info is very much appreciated.

[ghost]

I just submitted a PR, but unsure if it need a unit test in the commit.