search

wetcat-studios / fortie

Laravel 5 package for Fortnox API
Apache License 2.0
19 stars 20 forks source link

Added method to remove absence transaction #60

Closed jongotlin closed 4 years ago

jongotlin commented 4 years ago

Any chance this (and my other prs) can get merged? 🙏

agoransson commented 4 years ago

Of course.

I should just give you rights to merge and release also =)

jongotlin commented 4 years ago

Thanks for merging. Can you also tag a release? I don't mind not having merge access but if you want help maintaining this repo I can sure help.

agoransson commented 4 years ago

Sorry, I started it this morning but meetings meetings and other activities... then forgot again.

agoransson commented 4 years ago

TAG! You're it!! =)

I will (try to remember and...) write a sum-up on making releases in the readme. But it's quite simple.

  1. PR into dev, wait for travis tests (there are none), then merge into dev - squash or not (either is fine).
  2. When ready for a new release (usually after each PR), create a new releases/1.0.x branch and tag it.
  3. Push release branch, wait for travis.
  4. All is fine... merge into dev and master. Push push with tags. Packagist will automatically update the new version based on the new tag.

(I use SourceForge git-flow plugin for this repo)

For anyone else reading this (hint: @viktormaar =) feel free to let me know if you also want access to update and maintain.

jongotlin commented 4 years ago

Thanks!