search

wetcat-studios / fortie

Laravel 5 package for Fortnox API
Apache License 2.0
19 stars 20 forks source link

Coding standards proposal #68

Closed viktormaar closed 4 years ago

viktormaar commented 4 years ago

As the most effortless solution for the issue https://github.com/wetcat-studios/fortie/issues/66 I simply added the ruleset I use for Laravel projects. It is based on PSR-2 standards (as Laravel follows that as well) with some customization. A further discussion between the maintainers/contributors may needed, which rules we want or don´t want, but this can be a good base. Applying the rules is always easy, either by command line tool or by text editor extension.

Note: This PR does not contain any functional changes, only code formatting.

agoransson commented 4 years ago

Excellent! Let's wait and see what others think before we merge it though. But this is exactly what I'd like to see, use of standardised tools and guidelines instead of weird coding-habits from guys like me.

agoransson commented 4 years ago

@jongotlin

agoransson commented 4 years ago

I think this will be a nice base for a version 2.0 change since it's so big.