wethegit / component-library

WTC's internal React component library.
https://wethegit.github.io/component-library/
MIT License
0 stars 0 forks source link

[COMP] Flex: fix responsive classnames #181

Closed andrewrubin closed 2 months ago

andrewrubin commented 2 months ago

Description

Adds a missing dash to the breakpoint classnames. Fixes #172

Additional Notes

As we discussed in #172, we ought to update the buildBreakpointClassnames utility to not only honor the large-up breakpoints, as that is a specific grid-layout opinion. The <Flex> component, for example, should be able to receive specific values for small and medium as well. I am making a separate issue for that though!

Screenshots

This screencap illustrates the justify prop using the following responsive options:

<Flex justify={{ md: "flex-start", lg: "center", xxl: "flex-end" }}>
  <span>I</span>
  <span>am</span>
  <span>so</span>
  <span>cool</span>
</Flex>

https://github.com/wethegit/component-library/assets/30575213/63376902-da97-4607-a698-5d8c186cbcd2

changeset-bot[bot] commented 2 months ago

⚠️ No Changeset found

Latest commit: d9d7f5226766cf68d1138f56c83c9c78f21b70e3

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR