[COMP] BackToTop: various fixes, per project implementation

wethegit / component-library

WTC's internal React component library.

https://wethegit.github.io/component-library/

MIT License

0 stars 0 forks source link

[COMP] BackToTop: various fixes, per project implementation #187

Closed andrewrubin closed 5 months ago

andrewrubin commented 5 months ago

Description

This PR fixes a few blunders that I didn't catch until using <BackToTop> on a project:

Set inView callback to only fire at the 0 threshold instead of 1
Add missing useCallback dependencies
other minor tweaks

Also removes the dependency on the COLORS utility, as it's not something a user will necessarily want.

changeset-bot[bot] commented 5 months ago

⚠️ No Changeset found

Latest commit: 78944b2779e1891d6c533f723c169fb3e1e1eec1

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR