wethegit / component-library

WTC's internal React component library.
https://wethegit.github.io/component-library/
MIT License
0 stars 0 forks source link

feature: `Accordion` component #189

Closed consolecmnd closed 4 months ago

consolecmnd commented 5 months ago

My first StoryBook component so there will be missing details.

Improvements:

ReducedMotion Currently using @media styles and not const { prefersReducedMotion } = useUserPrefs()

Icon Component I don't think it's implemented it correctly

ReadMe Possibly lacking detail

TS Guessing Typescript implementation isn't perfect

Responsiveness Accordion height updated on click, not window resize

Takes strings or objects and wraps in < p >. More content design thought needed here

Remove DEFAULT_TAG? Seems verbose for how it's used here

changeset-bot[bot] commented 5 months ago

⚠️ No Changeset found

Latest commit: 6ac5d15eae1b86338e17790e5e40080e02a0b568

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR