Closed rvno closed 3 days ago
Latest commit: ba708eff04574f7d1972fb9c3a10325f1fe01fa7
Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.
Click here to learn what changesets are, and how to add one.
Click here if you're a maintainer who wants to add a changeset to this PR
Description
Adds tests for the
Icon
component testing thearia-hidden
andaria-label
attributes; addresses #130 .Solution
Creates a
Story
for two cases - rendering anIcon
with and without analt
prop value.Testing
cd packages/wethegit-components
, followed byyarn start
yarn test-storybook
http://localhost:6006/?path=/story/components-icon--default
andhttp://localhost:6006/?path=/story/components-icon--with-alt
and verify that the tests under theInteractions
tab have all passed, respectivelyControls
tab and try setting values there, hitting the refresh icon by the top of the canvas and verifying the tests run and pass in theInteractions
tab