wetneb / openrefine-wikibase

This repository has migrated to:
https://gitlab.com/nfdi4culture/ta1-data-enrichment/openrefine-wikibase
Other
100 stars 24 forks source link

Latest Jinja causing Docker build to fail. #137

Closed paulduchesne closed 2 years ago

paulduchesne commented 2 years ago

Observed behaviour

Docker will not build reconcile_1 container due to new versions of Jinja (> 3.1) including breaking changes.

reconcile_1 | Traceback (most recent call last): reconcile_1 | File "app.py", line 8, in reconcile_1 | from quart import Quart, render_template, request, g reconcile_1 | File "/usr/local/lib/python3.7/site-packages/quart/init.py", line 3, in reconcile_1 | from jinja2 import escape, Markup reconcile_1 | ImportError: cannot import name 'escape' from 'jinja2' (/usr/local/lib/python3.7/site-packages/jinja2/init.py) openrefine-wikibase_reconcile_1 exited with code 1

Proposed solution

-> add jinja2==3.0.3 to requirements.txt

Happy to open a PR for this fix.

wetneb commented 2 years ago

Thanks for reporting! A PR would be amazing.

wetneb commented 2 years ago

Closed by #138.