search

wetransform-os / ProMCDA

A tool to estimate ranks of alternatives and their uncertainties based on the Multi Criteria Decision Analysis approach.
Eclipse Public License 2.0
5 stars 1 forks source link

Better code quality with static code analysis #20

Closed B3J4y closed 7 months ago

B3J4y commented 8 months ago

There are some flaws in your code that could be addressed through static code analysis. For a lighter version focused mostly on code style, you can use flake8. The command for this is flake8 ./mcda. Many of these issues can be automatically fixed by your IDE. For a more rigorous code analysis, you can use pylint, which delves deeper into code quality. The command for this is pylint ./mcda/**/*.py. Addressing these issues after a long development process can be a significant workload. However, once it's done, the ongoing effort is minimal, and the code quality receives a substantial boost.

From my perspective, using static code analysis is not mandatory for the review, but it's a valuable addition to enhance code quality.

Flaminietta commented 8 months ago

Hi, I have never used those tools and I am happy to try them out. I'll let you know about any progress in this thread. I'll open a new branch if I see the workload is relatively big.