wetransform-os / ProMCDA

A tool to estimate ranks of alternatives and their uncertainties based on the Multi Criteria Decision Analysis approach.
Eclipse Public License 2.0
5 stars 1 forks source link

Paper: add plots to illustrate some of the package's functionality #23

Closed paulrougieux closed 2 months ago

paulrougieux commented 9 months ago

Comments on JOSS_paper/paper.md in the version available at commit 11a34a0 “add paper preprint” by Flaminia Catalli.

decision makers (DMs) Acronym is only used two other times. Just keep it as a word "decision makers" it's less confusing.

Can you illustrate the paper with a couple of plots? See for example the plots done in the JOSS paper describing the Coinr package.

There are several plotting functions in mcda/utils.py

plot_norm_scores_without_uncert
plot_non_norm_scores_without_uncert
plot_mean_scores
plot_mean_scores_iterative

These functions could be used with sample data to generate a plot illustrating some of the functionality of the package.

This is related to https://github.com/openjournals/joss-reviews/issues/6190

github-actions[bot] commented 9 months ago

Hello @paulrougieux, thank you for submitting an issue. We will take care of it.

mspada commented 4 months ago

Hi @paulrougieux, your suggestion is valid, but it fits well to a library with plotting methods, which is not the case of ProMCDA. By the way, no function of ProMCDA can be called by the user like e.g. _promcda.plot_meanscores yet. Instead, it generates basic figures in the browser as well as in the output folder for quick visualization. For these reasons we would prefer to leave the text as it is and consider improving the visualization functionality of ProMCDA in the process of rebuilding it as a library. Would you be fine with this decision?