search

wetransform-os / ProMCDA

A tool to estimate ranks of alternatives and their uncertainties based on the Multi Criteria Decision Analysis approach.
Eclipse Public License 2.0
5 stars 1 forks source link

Cannot terminate the process #27

Closed B3J4y closed 2 months ago

B3J4y commented 8 months ago

After running the toy example, the process did not finish, and I was unable to terminate it properly.

Flaminietta commented 6 months ago

Dear @B3J4y, in the main branch, latest commit e071d84, the toy example runs and finishes as expected for me.

Screenshot 2024-03-15 at 14 08 41

If you can try it again and confirm that everything is fine, I can close this issue. Thank you!

B3J4y commented 3 months ago

Sorry, the problem is still there:
ProMCMA

I left it open for a while to look if there was a calculation which needs some time, but this process doesn't come back.

I use windows.

mspada commented 3 months ago

@B3J4y I run the test on windows at it works smooth. Just a question: did the figures open on your browser or not? If not it might be a problem with some close ports that do not allow plotly to open the figures and, therefore, not ending the process. Let us know!

B3J4y commented 2 months ago

There are 2 figures. I append the open images: Figure1 Figure2

mspada commented 2 months ago

@B3J4y Thank you! Therefore, there might be some issue with the saving of some of the output files. When you run it, is it saving some output files in the output directory or not? If yes, what output files is ProMCDA saving?

B3J4y commented 2 months ago

You're welcome. It is tough to fix bugs remotely on another machine without having direct access. Hopefully, we can manage this.

Here is an image of the output folder:

Output_files

The red files are new. (red is the color for untracked files in IntelliJ)

mspada commented 2 months ago

Perfect, thanks! I know this is quite a tough way to try to fix an issue. In any case, it looks like that the issue is related to the figures, probably in the saving of them in the output folder. I'll have a look at it. I'll keep you posted

mspada commented 2 months ago

@B3J4y I guess I found the issue. It looks like that it is related to kaleido, which is used to save the static image of the plotly plots. In some cases (only on windows and not for everyone) the new version of kaleido (0.2.1), which is used in ProMCDA, is not correctly working. To solve this the community propose to downgrade kaleido to the version 0.1.0.post1 as discussed in https://community.plotly.com/t/static-image-export-hangs-using-kaleido/61519 and https://github.com/plotly/Kaleido/issues/126 Could you please try to downgrade kaleido to the version 0.1.0.post1 and run the test once again?

B3J4y commented 2 months ago

@mspada Thank you for finding the solution. I haven't had the time to downgrade Kaleido, and I feel that whether it works or not, your package will be very weak in terms of reusability if it relies on this mechanism for your Windows users. Could you possibly package it into a Docker container and add a Dockerfile to the repository? This could solve the Windows problems and provide users with a system-independent way to run the software.

Flaminietta commented 2 months ago

Dear @B3J4y, your request is addressed in this PR (ProMCDA is now also dockerized).