Closed Flaminietta closed 1 year ago
@mspada What I still did not do for all the norm Python functions is to test them against the R-functions, something I can easily do next. I'll report on these tests soon.
All normalization functions have been tested against the ones implemented in R. minmax reverse is now correct. All norm functions produce the same results in both implementation.
Thanks Flaminia, all fine to me
@mspada @kapil-agnihotri
The PR is now ready for your final review. It adds:
python3 -m mcda.mcda_run -c configuration_without_uncertainty.json
)
python -m pytest -s tests/unit_tests/
)I'll squash the commits during the merge.
I'd like to open an intermediary PR.
In this PR all the normalization functions (the ones present in the R-code) are implemented and tested. For now, I am considering only an MCDA run with no variability analysis (no Monte Carlo sampling).
The next steps will then be:
Please, have a look at the logic in particular, by testing I've seen that it is simple to make distraction errors in the implementation of the functions.