wetware / pkg

Peer-to-peer cloud environment

https://wetware.run

Other

37 stars 7 forks source link

Dial move #69

Closed evan-schott closed 1 year ago

evan-schott commented 1 year ago

65

Changed:

Moved the call to Dial from newClientNode in internal/cmd/cluster/cluster.go to setup in internal/cmd/cluster/cluster.go.
- Now fail gracefully when trying to publish message to topic without any ww start instances.
Added Before and After fields to the cluster cli.Command
- Now no panic when type in something wrong like ww cluster publish

Uncertainties

I removed the app != nil check from teardown under the assumption that it was a temporary fix.
I'm pretty sure that the error returned from Dial() is being lost, but not really sure how that can be included.

lthibault commented 1 year ago

Looks good! Waiting for tests to pass, and then merging.