wevisdemo / parliament-watch

Citizens are watching 👀
https://parliamentwatch.wevis.info
Other
61 stars 33 forks source link

Display invalid status label color in some voting page #114

Closed Th1nkK1D closed 3 weeks ago

Th1nkK1D commented 3 weeks ago

Describe the bug The voting page for voting prime minister shows an invalid status label text color.

To Reproduce Steps to reproduce the behavior:

  1. Go to the voting เลือก พิธา ลิ้มเจริญรัตน์ เป็นนายกฯ and เลือก เศรษฐา ทวีสิน เป็นนายกฯ
  2. Scroll down to "ผลการลงมติ" > "ผลการลงมติรายสังกัด" to see the bug

Expected behavior The status label text color should be the same as the corresponding status.

Screenshots

image

Additional context

svnnynior commented 3 weeks ago

Since my PR (#112) is kind of blocked with some pending questions atm. Can I pick this up as well?

Th1nkK1D commented 3 weeks ago

@svnnynior thank you for your enthusiasm, I already got the answers, will reply to the issue soon as possible so you don't hold many issues at the same time 🙏

nutchanon-c commented 3 weeks ago

I think I found where to fix this. It's a pretty simple fix. Can assign me if you want.

nutchanon-c commented 3 weeks ago

Opened PR just in case https://github.com/wevisdemo/parliament-watch/pull/124

Th1nkK1D commented 3 weeks ago

@nutchanon-c You are so fast! 🔥 I'll review you PRs tomorrow